Improve Timeout Configuration Clarity · Entire
i opened a PR and there are some comments. take a look for me. https://github.com/entireio/cli/pull/1487
3w ago·51.8s·10 calls
All three Copilot comments addressed and verified (lint clean, tests pass).
Fixes:
- transport.go — invalid-env warning now names the effective defaults:
using defaults (4s failover, 10s discovery), so it's actionable when debugging slow-link timeouts. - git-remote-entire/main.go — comment now references
DiscoveryDialTimeout(the actual call) and notesENTIRE_CONNECT_TIMEOUT_SECONDScan override it, instead of misleadingly citing the constant. - transport_test.go — renamed "unset …" cases to "blank …" (both DialTimeout and DiscoveryDialTimeout), since
t.Setenv(..., "")sets blank, not unset.
Want me to commit these? (Not pushing — your call.)
commit separately.
3w ago·24.9s·1 call
Three separate commits, one per comment.
ce0c3eeName effective defaults in invalid-timeout warning\n\nDiscovery and failover defaults differ, so "using defaults" alone was not\nactionable when debugging slow-link timeouts.\n\nCo-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com\nEntire-Checkpoint: be0e1af46fff+1/-1
b6f55d4Fix misleading discovery-dial-budget comment\n\nThe client uses DiscoveryDialTimeout(), which ENTIRE_CONNECT_TIMEOUT_SECONDS\ncan override, not the DefaultDiscoveryDialTimeout constant.\n\nCo-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com\nEntire-Checkpoint: 4cf6f00c27b3+3/-2
9cdac4eRename "unset" timeout test cases to "blank"\n\nt.Setenv with "" sets a blank value, not an unset one.\n\nCo-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com\nEntire-Checkpoint: 192662c5733c+2/-2