Fix misleading discovery-dial-budget comment · Entire

Fix misleading discovery-dial-budget comment

b6f55d4→main·

toothbrush·3w ago·1 file·+3 added/-2 removed

The client uses DiscoveryDialTimeout(), which ENTIRE_CONNECT_TIMEOUT_SECONDS can override, not the DefaultDiscoveryDialTimeout constant.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Sessions

4cf6f00c27b3View transcript

?\ Improve Timeout Configuration ClarityClaude Code·Opus 4.8[1m]·1 step

Changes

1

105 unmodified lines

106
107
108
109
110
109
110
111
112
113
114

105 unmodified lines

// This client drives the auth path only: cluster /.well-known discovery
    // and the token exchange. Both talk to a single control-plane host with no
    // failover to fall back on, so they get the patient discovery dial budget
    // (DefaultDiscoveryDialTimeout) rather than the short failover one — a slow
    // cold connect here would otherwise fail the whole clone/fetch.
    // (DiscoveryDialTimeout, i.e. DefaultDiscoveryDialTimeout unless
    // ENTIRE_CONNECT_TIMEOUT_SECONDS overrides it) rather than the short failover
    // one — a slow cold connect here would otherwise fail the whole clone/fetch.
    httpClient := &http.Client{
        Timeout: 30 * time.Second,
        Transport: &httpclient.UserAgentTransport{

Mcmd/git-remote-entire/main.go+3/-2