Rename "unset" timeout test cases to "blank" · Entire
Rename "unset" timeout test cases to "blank"
9cdac4e→main·
toothbrush·3w ago·1 file·+2 added/-2 removed
t.Setenv with "" sets a blank value, not an unset one.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Sessions
192662c5733cView transcript
[?
Improve Timeout Configuration ClarityClaude Code·Opus 4.8[1m]·1 step](/content/gh/entireio/cli/session/52f42b44-a279-405d-a413-4d922fc42be7#timeline-192662c5733c/index.html)
Changes
1
internal/entireclient/httpclient
Mtransport_test.go+2/-2
10 unmodified lines
11
12
13
14
14
15
16
17
17 unmodified lines
35
36
37
38
38
39
40
41
10 unmodified lines
env string
want time.Duration
}{
{"unset uses default", "", DefaultDialTimeout},
{"blank uses default", "", DefaultDialTimeout},
{"valid seconds", "10", 10 * time.Second},
{"single second", "1", 1 * time.Second},
{"non-integer falls back", "abc", DefaultDialTimeout},
17 unmodified lines
env string
want time.Duration
}{
{"unset uses discovery default", "", DefaultDiscoveryDialTimeout},
{"blank uses discovery default", "", DefaultDiscoveryDialTimeout},
{"override below default still wins", "2", 2 * time.Second},
{"override equal to default", "10", 10 * time.Second},
{"larger override wins", "20", 20 * time.Second},
Minternal/entireclient/httpclient/transport_test.go+2/-2