can you take a look again, we renamed the package name and I rebased onto main, also tests seem to fail · Entire
Summary of Changes
The following issues were addressed in the recent commits:
CI Test Flake - Resolved a cancellation race where the context cancellation propagated to the client before the malformed bytes were parsed, causing intermittent failures in CI. It was fixed in
internal/gitproto/fetch.go:55whereFetchToStorenow properly surfacescontext.Cancelederrors.- Commit Fix: Errors are preserved using
errors.Join()to ensure deterministic handling of cancellations.
- Commit Fix: Errors are preserved using
Lint Configuration Update - Fixed references to the old module path in
.golangci.yaml. The recent rename toentire.io/git-syncrequired updating the allow list to avoidauth.Methodwarnings that were incorrectly passing through.
Branch Status
The branch is currently 10 commits ahead of origin/soph/bump-go-git-v6-alpha2 following the rebase and fixes mentioned above. It is advised to execute git push --force-with-lease when you are ready to update the pull request.
Commit Information
- Commit ID:
98a36eb - Commit Message: Fix CI failures after go-git v6 upgrade and module rename.
Changes Overview
- Made cancellation tests deterministic by properly handling context cancellation errors.
- Updated
golangci.yamlto use the new module path.