Remove the Entire DB credential-store integration · Entire
Code Review Summary
Review the code changes against the base branch 'main'. The merge base commit for this comparison is 368750cee35f31935640a34ad199e889fc60f1a8. Run git diff 368750cee35f31935640a34ad199e889fc60f1a8 to inspect the changes relative to main. Provide prioritized, actionable findings.
Findings
Overall Correctness
- Patch Status: The patch is correct.
- Explanation: The changes correctly preserve report output while returning a non-zero error on failed benchmark runs, and clear unset sentinel values from aggregate summaries. I did not identify any regressions in the modified code paths.
- Confidence Score: 0.9
Detailed Changes
- Commit: 44f774c
- Description: Remove the Entire DB credential-store integration.
git-synccarried a bespoke Entire credential path:auth.Resolvefell back to an active-user lookup in~/.config/entire/hosts.jsonplus a file/keyring token store and OAuth refresh-token handling (client_id=entire-cli).- The mirror-pipeline worker now supplies credentials directly at the transport layer.
- Drop
entiredb.goandtokenstore.goand theLookupEntireDBCredentialfallback;auth.Resolvenow resolves explicit token/bearer credentials only and otherwise returnsnilso the git credential helper is consulted on a401. - This change drops the
github.com/zalando/go-keyringdependency, and removes thesyscall.Flockusage that broke the Windows build. - Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
- Entire-Checkpoint: de15fe82f1f3+18/-1384