Merge Main and Resolve Conflicts · Entire
Pull Request Summary
Merge Conflicts Resolution
- Timeframe: 2 weeks ago
- Duration: 3 minutes, 9 calls
Details
- Merged
origin/mainintoattach-improvementsand resolved the one conflict. - The conflict was in
cmd/entire/cli/attach_test.go, where both sides had touched the same assertion inTestAttachBlocksWhenPolicyWriteUnsupported:- This branch changed the
runAttachcall to pass a separate stderr writer. - Main strengthened the assertion to check the actual error message: "checkpoint policy cannot be satisfied by this Entire CLI".
- This branch changed the
- Resolution: Kept both — the two-writer call signature (matching the merged
attach.go) and main's stricter assertion.
Verification
go vetis clean.- All
TestAttach*tests incmd/entire/clipass. - The merge commit is
1e8484376. - Note: Did not run the full
mise run checksuite — recommended before pushing.
Push Summary
- Timeframe: 2 weeks ago
- Duration: 2 minutes, 7 calls
Details
- Successfully pushed changes after the first push was rejected due to the remote branch accepting a "Merge branch 'main'" commit (likely from GitHub's "Update branch" button).
- Merged
origin/attach-improvementscleanly; conflict resolution inattach_test.gowas untouched. - Lint and the attach tests passed on the final tree.
- Current state of
attach-improvements:064240698on origin.
Commit Reference
4b35fe0 Merge remote-tracking branch 'origin/attach-improvements' into attach-improvements