Review and Fix PR Code Nitpicks · Entire
have a look at https://github.com/entireio/cli/pull/1457 - there are heaps of nitpicks. fix only those that are actual issues - don't be browbeaten by Copilot because half the time it's wrong.
Bottom line: Of ~16 open nitpicks, only one was a real issue worth fixing — the rest were already-fixed, false, or theoretical.
Fixed (commit b82a741ef26):
- Added
t.Parallel()to all 10 cross-juris transport tests. Copilot's stated reason was wrong (tparallellint failure — lint passes 0 issues, andparalleltestisn't even enabled), but the repo's own CLAUDE.md mandatest.Parallel()and the siblingclient_test.gofollows it. Tests own their httptest servers/transports with no process-global state, so safe. Green under-race.
Declined — all genuinely non-issues:
- Host port/casing mismatch (cursor): both sides come from the same
JURISDICTION_AUTH_HOSTSconfig, byte-identical. Canonicalizing would diverge from the entiredb twin. toothbrush's reasoning holds. MaxBytesReaderpanic (Copilot): false — nil writer fails therequestTooLargertype assertion, so it's a no-op, not a panic.drainAndRestoreBodyno restore-on-error (Copilot, the refined re-take): unreachable in practice (8–64 KiB caps on tiny envelopes) and harmless when hit (read error = dead connection); the doc describes the success contract.validateExchangeURLexact-path (Copilot): pure defense-in-depth — same-origin+https already gates JWT exposure; a bad path just makes the exchange fail gracefully.
Already addressed before this session: the three -race shared-slice comments (fixed via authRecorder in 6a23ba488ac).
You'll want to push and optionally reply to the declined threads — I left those for you.
[b82a741test(coreapi): mark cross-juris transport tests parallel
All tests own their httptest servers/transports with no process-global
state, so they conform to the repo's t.Parallel() convention.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Entire-Checkpoint: 41b4654948eb+10](/content/gh/entireio/cli/commit/b82a741ef262e275f083c50ac87853c1717bc779/index.html)