Code Review Updates

Pull Request Merged

The pull request #14 is merged. Please update your local environment.

Dependencies Updated

-   github.com/entireio/auth-go v0.4.1-0.20260603110757-7103c3dc992a   (PR branch)
+   github.com/entireio/auth-go v0.4.1-0.20260603125945-62cd5140d2d4   (merged on main)

• go.mod / go.sum updated via go get + go mod tidy
• go build ./... passes
• auth + cli package tests pass (the typed sts.ExchangeError usage in repo_token.go/repo_mirror.go is compatible)

Changes Pending

The changes are in the working tree. Should I commit them (e.g. deps: bump auth-go to merged sts.ExchangeError)?

Code Comments

I reviewed the comment against the actual code in repo_mirror.go. The conclusion is:

Copilot is right, and it's a real inconsistency — though bounded in impact.

Why it’s Valid

The function's own doc comment states the precondition that isn’t enforced at the call site.

Caveats on Severity

• Without definitive repo verification, the auth gate may not be consistent with create.

Recommended Fix

The handler should be gated based on the precondition already claimed in the documentation.

if err := waitForMirrorClone(ctx, out, clusterHost, owner, repo, waitTimeout); err != nil {
    if !created.Created {
        if handled, serr := explainSuspendedMirror(cmd.ErrOrStderr(), created.MirrorId, err); handled {
            cmd.SilenceUsage = true
            return serr
        }
    }
    return err
}

Summary of Changes

1. Updated explainSuspendedMirror to take a freshCreate boolean.
2. Call site now passes created.Created to ensure correct behavior.
3. Added tests in repo_mirror_test.go.

Verification

• mise run lint clean (0 issues)
• TestExplainSuspendedMirror passes all subtests.

Next Steps

Shall I commit and push the changes? If so, I suggest two separate commits for clarity.