Update Trail Watch for Trail-Wide Events · Entire
entire.io branch dip/trail-wide-events-endpoint adopt/adjust the API for entire trail watch
3w ago · 5.2s · 60 calls
Implemented the entire trail watch API adjustment.
Changed:
cmd/entire/cli/trail_watch_cmd.go- Watch now streams
GET /api/v1/trails/<id>/events - Updated help text to trail-wide events
- Updated parsing/types for
review_id - Added nicer output for
review.started, runner events, and monitor updates
- Watch now streams
cmd/entire/cli/trail_watch_cmd_test.go- Updated endpoint expectation
- Updated SSE fixtures to trail-wide events
Validated with:
1
go test ./cmd/entire/cli
Create a PR.
3w ago · 13.1s · 5 calls
Created PR: https://github.com/entireio/cli/pull/1522
[0cad45fUpdate trail watch for trail-wide events
Entire-Checkpoint: 8259670f86bd+191/-107](/content/gh/entireio/cli/commit/0cad45f708503d9147bb7cc3599b030e7e8bbbc4/index.html)
Why is it getting so much more code if all we did is change the endpoint?
3w ago · 23.5s · 9 calls
You’re right — I over-scoped it.
I interpreted “trail-wide events” as needing new human-readable rendering for runner/monitor events and renamed some internals, which ballooned the diff. That wasn’t necessary for just adopting the new endpoint.
I’ve trimmed the PR down to only:
- update watch help text
- switch
/reviews/events→/events - update the path test
PR is force-updated now: https://github.com/entireio/cli/pull/1522
Tested:
1
go test ./cmd/entire/cli -run 'Test(StreamOnce|ReviewEventsPath)'
[4c6ebc1Update trail watch for trail-wide events
Entire-Checkpoint: 8259670f86bd+9/-9](/content/gh/entireio/cli/commit/4c6ebc16c88f78250d4c83bf111bf63a2a5386e0/index.html)