Code Review for Stores Architecture Reshape · Entire

Code Review of Commit 7b1005d31

Review the code changes introduced by commit 7b1005d31 ("checkpoint: reshape facade to Stores.Persistent / Stores.Ephemeral"). Provide prioritized, actionable findings.

Findings

{"findings":[],"overall_correctness":"patch is correct","overall_explanation":"The change consistently renames the checkpoint facade accessors and updates call sites. The affected packages compile and tests pass for cmd/entire/cli.","overall_confidence_score":0.92}

Commit Details

Commit Message: 99982c4checkpoint: name ephemeral writes by scope (Step / TaskStep)

Mirror the persistent union's verb-free, scope-based naming on the ephemeral side. The store method is already Write, so the request noun should say what is written, not repeat the verb: WriteCheckpoint -> Step (a session step) and WriteTask -> TaskStep (a subagent task step). Both still produce an ephemeral shadow-branch checkpoint; the names match the strategy's SaveStep / SaveTaskStep vocabulary. Bare nouns like checkpoint.Checkpoint were rejected — they stutter on the package's own central domain noun and read as a distinct kind when both requests write the same artifact from different sources.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com Entire-Checkpoint: ed0141adaf02+48/-48