emit policy-blocked telemetry from agent hooks

ee51d30→main·

pfleidi·2w ago·1 file·+49 added/-4

Agent session-start skips and turn-end/subagent-end/post-todo rejections caused by an unsupported or unreadable checkpoint policy now report a checkpoint_policy_blocked event, distinguishing skipped (session-start) from blocked (write hooks) outcomes.

Sessions

70ed1374c631View transcript

[?
Add Checkpoint Policy Blocked TelemetryClaude Code·1 step](/content/gh/entireio/cli/session/59674bd8-9edc-47fc-adae-9e93955ab9af#timeline-70ed1374c631/index.html)

Changes

1

• cmd/entire/cli

• Mhook_registry.go+49/-4

19 unmodified lines

20
21
22
23
24
25
26
153 unmodified lines

180
181
182
182
183
184
185
186
2 unmodified lines

189
190
191
191
192
193
194
195
196
26 unmodified lines

223
224
225
224
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
1 unmodified line

256
257
258
241
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
7 unmodified lines

294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310

19 unmodified lines

"github.com/entireio/cli/cmd/entire/cli/logging"
    "github.com/entireio/cli/cmd/entire/cli/paths"
    "github.com/entireio/cli/cmd/entire/cli/strategy"
    "github.com/entireio/cli/cmd/entire/cli/telemetry"
    "github.com/entireio/cli/cmd/entire/cli/versioncheck"
    "github.com/entireio/cli/cmd/entire/cli/versioninfo"
    "github.com/entireio/cli/perf"
153 unmodified lines

}

if eventType == agent.SessionStart {
        skipSessionStart, err := shouldSkipSessionStartForPolicy(ctx, cmd.ErrOrStderr(), ag, worktreeRoot)
        skipSessionStart, err := shouldSkipSessionStartForPolicy(ctx, cmd.ErrOrStderr(), agentName, ag, worktreeRoot)
        if err != nil {
            span.RecordError(err)
            return err
        }
    } else if hookWritesCheckpointData(eventType, claudePostTodoCheckpointHook) {
        if err := rejectUnsupportedCheckpointWritePolicy(ctx, cmd.ErrOrStderr(), worktreeRoot); err != nil {
            writeHook := agentWriteHookLabel(eventType, claudePostTodoCheckpointHook)
            if err := rejectUnsupportedCheckpointWritePolicy(ctx, cmd.ErrOrStderr(), agentName, writeHook, worktreeRoot); err != nil {
                span.RecordError(err)
                return err
            }
        }
26 unmodified lines

return !checkpointpolicy.CanSatisfyPolicy(policy)
}

func shouldSkipSessionStartForPolicy(ctx context.Context, errW io.Writer, ag agent.Agent, worktreeRoot string) (bool, error) {
func shouldSkipSessionStartForPolicy(ctx context.Context, errW io.Writer, agentName types.AgentName, ag agent.Agent, worktreeRoot string) (bool, error) {
    policy, err := agentHookPolicy(ctx, worktreeRoot)
    if err != nil {
        logging.Warn(ctx, "checkpoint policy read failed for agent hook",
            slog.String("error", err.Error()))
        emitCheckpointPolicyBlocked(ctx, telemetry.CheckpointPolicyBlockedEvent{
            Hook:     "session-start",
            HookType: telemetry.PolicyBlockedHookTypeAgent,
            Reason:   telemetry.PolicyBlockedReasonUnreadable,
            Outcome:  telemetry.PolicyBlockedOutcomeSkipped,
            Agent:    string(agentName),
        })
        // Let the agent start; the warning explains that checkpoint capture is
        // disabled until the policy can be read.
        return true, writeUnsupportedPolicySessionStartWarning(errW, ag, sessionStartPolicyReadErrorWarning(err))
    }
    if shouldSkipAgentHookForPolicy(policy) {
        emitCheckpointPolicyBlocked(ctx, telemetry.CheckpointPolicyBlockedEvent{
            Hook:                 "session-start",
            HookType:             telemetry.PolicyBlockedHookTypeAgent,
            Reason:               telemetry.PolicyBlockedReasonUnsupported,
            Outcome:              telemetry.PolicyBlockedOutcomeSkipped,
            Agent:                string(agentName),
            CheckpointVersion:    policy.CheckpointVersion,
            CheckpointMinVersion: policy.CheckpointMinVersion,
        })
        // Let the agent start; the warning explains that checkpoint capture is
        // disabled until the CLI is upgraded.
        return true, writeUnsupportedPolicySessionStartWarning(errW, ag, sessionStartPolicyWarning(policy))
    }

return false, nil
}

func rejectUnsupportedCheckpointWritePolicy(ctx context.Context, errW io.Writer, worktreeRoot string) error {
func rejectUnsupportedCheckpointWritePolicy(ctx context.Context, errW io.Writer, agentName types.AgentName, hook string, worktreeRoot string) error {
    policy, err := agentHookPolicy(ctx, worktreeRoot)
    if err != nil {
        logging.Warn(ctx, "checkpoint policy read failed for agent hook",
            slog.String("error", err.Error()))
        emitCheckpointPolicyBlocked(ctx, telemetry.CheckpointPolicyBlockedEvent{
            Hook:     hook,
            HookType: telemetry.PolicyBlockedHookTypeAgent,
            Reason:   telemetry.PolicyBlockedReasonUnreadable,
            Outcome:  telemetry.PolicyBlockedOutcomeBlocked,
            Agent:    string(agentName),
        })
        fmt.Fprint(errW, agentCheckpointCaptureDisabledReadErrorMessage(err))
        return NewSilentError(err)
    }
    if shouldSkipAgentHookForPolicy(policy) {
        emitCheckpointPolicyBlocked(ctx, telemetry.CheckpointPolicyBlockedEvent{
            Hook:                 hook,
            HookType:             telemetry.PolicyBlockedHookTypeAgent,
            Reason:               telemetry.PolicyBlockedReasonUnsupported,
            Outcome:              telemetry.PolicyBlockedOutcomeBlocked,
            Agent:                string(agentName),
            CheckpointVersion:    policy.CheckpointVersion,
            CheckpointMinVersion: policy.CheckpointMinVersion,
        })
        fmt.Fprint(errW, agentCheckpointCaptureDisabledMessage(policy))
        return NewSilentError(errUnsupportedCheckpointPolicy)
    }
7 unmodified lines

return eventType == agent.TurnEnd || eventType == agent.SubagentEnd
}

func agentWriteHookLabel(eventType agent.EventType, claudePostTodoCheckpointHook bool) string {
    switch {
    case claudePostTodoCheckpointHook:
        return "post-todo"
    case eventType == agent.SubagentEnd:
        return "subagent-end"
    default:
        return "turn-end"
    }
}

func sessionStartPolicyWarning(policy checkpointpolicy.Policy) string {
    message := "Entire CLI is enabled, but this repository's checkpoint policy requires a newer Entire CLI. No Entire checkpoints will be created for this session until you upgrade."
    details := strings.TrimSpace(checkpointpolicy.UnsupportedPolicyMessage(policy, versioncheck.UpdateCommandForCurrentBinary(versioninfo.Version)))