fix(agent-help): skip trail probe when logged out

e03e6a6 · dipree · 2d ago · 2 files · +43 added/-0 removed

Sessions

01KXJYA9NRAFDQ1PS32D360Q9W View transcript

Changes

2

• cmd/entire/cli

  • Magent_help_cmd.go +8
  • Magent_help_cmd_test.go +35

88 unmodified lines

// ResolveDataAPIToken performs data-host discovery before it can reject a
// missing login. The scope already carries the locally resolved auth identity,
// so avoid making an unauthenticated first run wait on a network request that
// cannot produce an enabled decision.
if scope.AuthKey == "" {
    return repoLine, false
}

refreshCtx, cancel := context.WithTimeout(ctx, trailEnablementRefreshTimeout)
defer cancel()
if err := refresh(refreshCtx, scope); err != nil {

Mcmd/entire/cli/agent_help_cmd.go +8

98 unmodified lines

// repo-scoped trails availability check instead of being treated as disabled.
// Not parallel: changes the process working directory.
func TestAgentHelpRepoContext_RefreshesUnknownTrailsEnablement(t *testing.T) {
    t.Setenv("ENTIRE_TOKEN", makeTestJWT(t, `{"iss":"https://auth.entire.io","sub":"user-1","handle":"alice","aud":"https://entire.io"}`))
    repoDir := t.TempDir()
    testutil.InitRepo(t, repoDir)
    cmd := exec.CommandContext(t.Context(), "git", "remote", "add", "origin", "git@github.com:acme/app.git")
}

// Without a local auth identity, refreshing cannot produce a usable trails // decision. Skip it locally so agent-help does not block on API discovery before // auth eventually reports that the user is not logged in. // Not parallel: changes the process working directory and auth environment. func TestAgentHelpRepoContext_SkipsRefreshWithoutLocalIdentity(t *testing.T) { t.Setenv("ENTIRE_TOKEN", "") t.Setenv("ENTIRE_CONFIG_DIR", t.TempDir()) repoDir := t.TempDir() testutil.InitRepo(t, repoDir) cmd := exec.CommandContext(t.Context(), "git", "remote", "add", "origin", "git@github.com:acme/app.git") cmd.Dir = repoDir cmd.Env = testutil.GitIsolatedEnv() if err := cmd.Run(); err != nil { t.Fatalf("git remote add: %v", err) } t.Chdir(repoDir)

refreshCalls := 0 repoLine, enabled := agentHelpRepoContextWithRefresh(t.Context(), func(context.Context, trailEnablementScope) error { refreshCalls++ return nil })

if refreshCalls != 0 { t.Fatalf("refresh calls = %d, want 0 without a local auth identity", refreshCalls) } if repoLine != "gh/acme/app" { t.Errorf("repo line = %q, want gh/acme/app", repoLine) } if enabled { t.Fatal("trails should not be advertised without a local auth identity") } }

// Drilling into a trail-gated command is blocked when trails are disabled. func TestRunAgentHelp_TrailDrillGatedOnTrailsEnabled(t *testing.T) { t.Parallel()