merge: fix lint after review updates

be0c7df→main·

dipree·3w ago·3 files·+7 added/-9 removed

Sessions

53f391bcf8f9View transcript

[?
Checkout the hand off doc that I just added.Pi·Opus 4.8·2 steps](/content/gh/entireio/cli/session/019eca64-8c2c-7b00-90c6-3aa49738c497#timeline-53f391bcf9/index.html)

Changes

3

• cmd/entire/cli

• checkpoint

• Mopen.go+4/-6

• Mreview_bridge_test.go+1/-1

• strategy

• Mmanual_commit.go+2/-2

22 unmodified lines

23
24
25
26
27
26
27
28
29
29
30
31
32
22 unmodified lines

55
56
57
58
59
60
58
59
60
61

22 unmodified lines

// Stores is the facade returned by Open: the committed store plus the git-only
// temporary capability and resolved committed-ref topology.
type Stores struct {
    // Primary is the committed store that serves committed reads and writes.
    Primary CommittedStore
    // Primary is the git-backed committed store that serves committed reads and writes.
    Primary *GitStore

temporary TemporaryStore
    temporary *GitStore
    refs      CommittedRefs
}

22 unmodified lines

}

// Temporary returns the git-backed temporary shadow-branch store.
//
//nolint:ireturn // temporary store capability is the abstraction boundary
func (s *Stores) Temporary() TemporaryStore { return s.temporary }
func (s *Stores) Temporary() *GitStore { return s.temporary }

// Refs returns the resolved committed-ref topology.
func (s *Stores) Refs() CommittedRefs { return s.refs }

Mcmd/entire/cli/checkpoint/open.go+4/-6

102 unmodified lines

103
104
105
106
106
107
108
109

102 unmodified lines

if inputs[1].Severity == nil || *inputs[1].Severity != "medium" {
        t.Fatalf("severity[1] = %v, want medium", inputs[1].Severity)
    }
    if inputs[0].Location.Granularity != "line" || inputs[0].Location.FilePath == nil || *inputs[0].Location.FilePath != "api/src/lib/planetscale/trails.ts" || inputs[0].Location.StartLine == nil || *inputs[0].Location.StartLine != 657 {
        if inputs[0].Location.Granularity != reviewTrailGranularityLine || inputs[0].Location.FilePath == nil || *inputs[0].Location.FilePath != "api/src/lib/planetscale/trails.ts" || inputs[0].Location.StartLine == nil || *inputs[0].Location.StartLine != 657 {
            t.Fatalf("location[0] = %+v, want trails.ts:657", inputs[0].Location)
        }
    }
}

Mcmd/entire/cli/review_bridge_test.go+1/-1

51 unmodified lines

52
53
54
55
55
56
57
58
3 unmodified lines

62
63
64
65
65
66
67
68

51 unmodified lines

// topology. Writes target refs.Primary; reads target refs.Read. The strategy's
// blob fetcher is wired in so reads can fetch blobs on demand after a treeless
// fetch.
func (s *ManualCommitStrategy) getCheckpointStore(ctx context.Context, repo *git.Repository) (checkpoint.CommittedStore, error) { //nolint:ireturn // committed store capability is the abstraction boundary
func (s *ManualCommitStrategy) getCheckpointStore(ctx context.Context, repo *git.Repository) (*checkpoint.GitStore, error) {
    stores, err := s.getCheckpointStores(ctx, repo)
    if err != nil {
        return nil, err
    }
3 unmodified lines

// getTemporaryStore returns the git-backed shadow-branch store with the
// strategy's blob fetcher wired in.
func (s *ManualCommitStrategy) getTemporaryStore(ctx context.Context, repo *git.Repository) (checkpoint.TemporaryStore, error) { //nolint:ireturn // temporary store capability is the abstraction boundary
func (s *ManualCommitStrategy) getTemporaryStore(ctx context.Context, repo *git.Repository) (*checkpoint.GitStore, error) {
    stores, err := s.getCheckpointStores(ctx, repo)
    if err != nil {
        return nil, err
    }