checkpoint: add domain store adapters · Entire
checkpoint: add domain store adapters
a9fb6e7·
pfleidi·4w ago·3 files·+548 added/-0 removed
Introduce session and checkpoint document interfaces over the existing git committed storage layout.
The new GitStore adapters preserve the old on-disk behavior while exposing SessionRef-based reads and option-based backfills for later caller migration.
Sessions
51f5a0ee3b11View transcript
Changes
3
cmd/entire/cli/checkpoint
Acommitted_domain.go+461
Mcommitted_reader_resolve_test.go+85
Mstore.go+2
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
78 unmodified lines
require.Equal(t, []byte("latest transcript\n"), transcript)
}
func TestGitStoreSessionStoreReadsByRef(t *testing.T) {
t.Parallel()
repoDir := t.TempDir()
testutil.InitRepo(t, repoDir)
repo, err := git.PlainOpen(repoDir)
require.NoError(t, err)
store := NewGitStore(repo, DefaultV1Refs())
cx := context.Background()
cpID := id.MustCheckpointID("333333333333")
writeSessionForStoreTest(t, store, cpID, "session-a", "first transcript\n", "first prompt")
writeSessionForStoreTest(t, store, cpID, "session-b", "latest transcript\n", "latest prompt")
latest, err := store.ReadSession(cx, LatestSessionRef(cpID))
require.NoError(t, err)
require.Equal(t, "session-b", latest.Metadata.SessionID)
require.Equal(t, []byte("latest transcript\n"), latest.Transcript)
metadataOnly, err := store.ReadSession(cx, SessionIndexRef(cpID, 0), WithSessionMetadataOnly())
require.NoError(t, err)
require.Equal(t, "session-a", metadataOnly.Metadata.SessionID)
require.Empty(t, metadataOnly.Transcript)
require.Empty(t, metadataOnly.Prompts)
metadataAndPrompts, err := store.ReadSession(cx, SessionIDRef(cpID, "session-a"), WithSessionMetadataAndPrompts())
require.NoError(t, err)
require.Equal(t, "session-a", metadataAndPrompts.Metadata.SessionID)
require.Equal(t, "first prompt", metadataAndPrompts.Prompts)
require.Empty(t, metadataAndPrompts.Transcript)
infos, err := store.ListCheckpoints(cx)
require.NoError(t, err)
require.Len(t, infos, 1)
require.Equal(t, cpID, infos[0].CheckpointID)
}
func TestGitStoreStoresUpdateSpecificSessionAndCheckpoint(t *testing.T) {
t.Parallel()
repoDir := t.TempDir()
testutil.InitRepo(t, repoDir)
repo, err := git.PlainOpen(repoDir)
require.NoError(t, err)
store := NewGitStore(repo, DefaultV1Refs())
cx := context.Background()
cpID := id.MustCheckpointID("444444444444")
sessionSummary := &Summary{Intent: "summarize first session"}
require.NoError(t, store.UpdateSession(cx, SessionIDRef(cpID, "session-a"), WithSummary(sessionSummary)))
first, err := store.ReadSession(cx, SessionIDRef(cpID, "session-a"), WithSessionMetadataOnly())
require.NoError(t, err)
require.Equal(t, sessionSummary.Intent, first.Metadata.Summary.Intent)
second, err := store.ReadSession(cx, SessionIDRef(cpID, "session-b"), WithSessionMetadataOnly())
require.NoError(t, err)
require.Nil(t, second.Metadata.Summary)
attribution := &InitialAttribution{AgentLines: 7, TotalCommitted: 11}
require.NoError(t, store.UpdateCheckpoint(cx, cpID, WithAttribution(attribution)))
checkpointSummary, err := store.ReadCheckpoint(cx, cpID)
require.NoError(t, err)
require.Equal(t, 7, checkpointSummary.CombinedAttribution.AgentLines)
require.Equal(t, 11, checkpointSummary.CombinedAttribution.TotalCommitted)
}
func writeSessionForStoreTest(t *testing.T, store *GitStore, cpID id.CheckpointID, sessionID, transcript, prompt string) {
t.Helper()
require.NoError(t, store.WriteSession(t.Context(), SessionIDRef(cpID, sessionID), Session{
Strategy: "manual-commit",
Transcript: redact.AlreadyRedacted([]byte(transcript)),
Prompts: []string{prompt},
AuthorName: "Test",
AuthorEmail: "test@example.com",
}))
}
func (opts writeOptions) hasTranscriptUpdate() bool {
return opts.transcriptSet || opts.promptsSet || opts.skillEventsSet || opts.precomputedBlobs != nil
}
func (opts writeOptions) hasSessionUpdate() bool {
return opts.hasTranscriptUpdate() || opts.summarySet
}