Reject empty finding update fields

99ba865→main· dipree·4w ago·2 files·+16 added/-8 removed

Sessions

238d17ea0fabView transcript

?\ Validate Empty Body Error HandlingPi·GPT-5.5·2 steps

Changes

2

• cmd/entire/cli

• Mtrail_review_cmd.go+10/-8

• Mtrail_review_cmd_test.go+6

688 unmodified lines

func buildTrailReviewCommentPatchRequest(opts trailReviewUpdateOptions) (api.TrailReviewCommentPatchRequest, error) {
    var req api.TrailReviewCommentPatchRequest
    if opts.BodyChanged {
        req.Body = stringPtr(strings.TrimSpace(opts.Body))
        body := strings.TrimSpace(opts.Body)
        if body == "" {
            return req, errors.New("finding body is required (pass --body)")
        }
        req.Body = stringPtr(body)
    }
    if opts.SeverityChanged {
        severity := strings.ToLower(strings.TrimSpace(opts.Severity))
        if severity != "" {
            switch severity {
            case trailReviewSeverityHigh, trailReviewSeverityMedium, trailReviewSeverityLow:
            default:
                return req, fmt.Errorf("invalid severity %q: valid values are high, medium, low", opts.Severity)
            }
        switch severity {
            case trailReviewSeverityHigh, trailReviewSeverityMedium, trailReviewSeverityLow:
                req.Severity = stringPtr(severity)
            default:
                return req, fmt.Errorf("invalid severity %q: valid values are high, medium, low", opts.Severity)
            }
        req.Severity = stringPtr(severity)
        }
    if opts.ConfidenceChanged {
        if opts.Confidence < 0 || opts.Confidence > 1 {

Mcmd/entire/cli/trail_review_cmd.go+10/-8

213 unmodified lines

if _, err := buildTrailReviewCommentPatchRequest(trailReviewUpdateOptions{Severity: "urgent", SeverityChanged: true}); err == nil {
        t.Fatal("expected an error for invalid severity")
    }
    if _, err := buildTrailReviewCommentPatchRequest(trailReviewUpdateOptions{Body: " ", BodyChanged: true}); err == nil {
        t.Fatal("expected an error for empty body")
    }
    if _, err := buildTrailReviewCommentPatchRequest(trailReviewUpdateOptions{Severity: " ", SeverityChanged: true}); err == nil {
        t.Fatal("expected an error for empty severity")
    }
}

func TestBuildTrailReviewCommentInput(t *testing.T) {

Mcmd/entire/cli/trail_review_cmd_test.go+6