refactor(review): reviewerTimeout body to max() as well (review feedback) · Entire
refactor(review): reviewerTimeout body to max() as well (review feedback)
6232e22→main·
peyton-alt·1w ago·1 file·+1 added/-4 removed
Same shape as judgeTimeoutArg one commit earlier: the named function stays (its doc comment carries the no-default-timeout rationale), the two-state arithmetic becomes builtin max.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Sessions
01KX0P0XW5TXCPJY4G65B8N82VView transcript
[?
test(review): pin that codex $name skills survive the legacy repair + native invocationClaude Code·16 steps](/content/gh/entireio/cli/session/99f0d90a-6e31-4c60-ba62-aa2dccd29033#timeline-01KX0P0XW5TXCPJY4G65B8N82V/index.html)
Changes
1
cmd/entire/cli/review
Mrun.go+1/-4
46 unmodified lines
47
48
49
50
51
52
53
50
51
52
53
46 unmodified lines
// - positive: hard cap.
// - zero or negative: no cap.
func reviewerTimeout(cfg reviewtypes.RunConfig) time.Duration {
if cfg.ReviewerTimeout > 0 {
return cfg.ReviewerTimeout
}
return 0
return max(cfg.ReviewerTimeout, 0)
}
var errReviewerTimeoutCause = errors.New("reviewer timeout elapsed")
Mcmd/entire/cli/review/run.go+1/-4