fix(e2e): align factory file wait with documented Worker bound · Entire
fix(e2e): align factory file wait with documented Worker bound
515ced2→main·
pfleidi·2w ago·1 file·+2 added/-2 removed
The adjacent comment documents Worker turns of 60-120s on CI but the file wait was capped at 90s, so a slow Worker could outlive the wait even when it succeeds. Droid's 2x timeout multiplier gives these tests a 6-minute budget, so the wider wait fits comfortably.
Sessions
132cc906436eView transcript
[?
Debug E2E Test Timing IssuesClaude Code·Opus 4.8[1m]·5 steps](/content/gh/entireio/cli/session/58280a70-c670-4b2d-a1c8-80439ef7460d#timeline-132cc906436e/index.html)
Changes
1
e2e/tests
Mfactory_hooks_test.go+2/-2
33 unmodified lines
34
35
36
37
37
38
39
40
21 unmodified lines
62
63
64
65
65
66
67
68
33 unmodified lines
// WaitFor can return while droid is still working: the input box's
// "> Enter to steer" matches the prompt pattern even mid-turn, so the
// file wait must absorb the Worker's runtime (60-120s turns on CI).
testutil.WaitForFileExists(t, s.Dir, "docs/factory-hook-check.md", 90*time.Second)
testutil.WaitForFileExists(t, s.Dir, "docs/factory-hook-check.md", 120*time.Second)
waitForTaskRewindPoint(t, s.Dir, 30*time.Second)
})
21 unmodified lines
// See TestFactoryTaskCheckpointExistsBeforeCommit: the file wait must
// absorb the Worker's runtime because WaitFor can return mid-turn.
testutil.WaitForFileExists(t, s.Dir, "docs/factory-prehook-worker.md", 90*time.Second)
testutil.WaitForFileExists(t, s.Dir, "docs/factory-prehook-worker.md", 120*time.Second)
waitForTaskRewindPoint(t, s.Dir, 30*time.Second)
s.Git(t, "add", "docs/factory-prehook-worker.md")
Me2e/tests/factory_hooks_test.go+2/-2