chore: drop now-unused //nolint:ireturn directives · Entire
chore: drop now-unused //nolint:ireturn directives
2749cb4·
toothbrush·3w ago·2 files·+3 added/-3 removed
After rebasing onto origin/main the ireturn linter no longer fires on these capability-boundary returns, so the directives are unused and nolintlint fails CI on them. Removed by golangci-lint --fix.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Sessions
3373f6e16437View transcript
[?
Control Plane Delete and Revoke SafetyClaude Code·Opus 4.8[1m]·2 steps](/content/gh/entireio/cli/session/8e196be2-884b-4372-a672-2e81e2857e10#timeline-3373f6e16437/index.html)
Changes
2
cmd/entire/cli
checkpoint
Mopen.go+1/-1
strategy
Mmanual_commit.go+2/-2
54 unmodified lines
55
56
57
58
58
59
60
61
54 unmodified lines
}
// Temporary returns the git-backed temporary shadow-branch store.
func (s *Stores) Temporary() TemporaryStore { return s.temporary } //nolint:ireturn // temporary store capability is the abstraction boundary
func (s *Stores) Temporary() TemporaryStore { return s.temporary }
// Refs returns the resolved committed-ref topology.
func (s *Stores) Refs() CommittedRefs { return s.refs }
Mcmd/entire/cli/checkpoint/open.go+1/-1
51 unmodified lines
52
53
54
55
55
56
57
58
3 unmodified lines
62
63
64
65
65
66
67
68
51 unmodified lines
// topology. Writes target refs.Primary; reads target refs.Read. The strategy's
// blob fetcher is wired in so reads can fetch blobs on demand after a treeless
// fetch.
func (s *ManualCommitStrategy) getCheckpointStore(ctx context.Context, repo *git.Repository) (checkpoint.CommittedStore, error) { //nolint:ireturn // committed store capability is the abstraction boundary
func (s *ManualCommitStrategy) getCheckpointStore(ctx context.Context, repo *git.Repository) (checkpoint.CommittedStore, error) {
stores, err := s.getCheckpointStores(ctx, repo)
if err != nil {
return nil, err
3 unmodified lines
// getTemporaryStore returns the git-backed shadow-branch store with the
// strategy's blob fetcher wired in.
func (s *ManualCommitStrategy) getTemporaryStore(ctx context.Context, repo *git.Repository) (checkpoint.TemporaryStore, error) { //nolint:ireturn // temporary store capability is the abstraction boundary
func (s *ManualCommitStrategy) getTemporaryStore(ctx context.Context, repo *git.Repository) (checkpoint.TemporaryStore, error) {
stores, err := s.getCheckpointStores(ctx, repo)
if err != nil {
return nil, err