inspect: pin --local as interactive scope preselection

15d3f21→main·

dipree·4w ago·2 files·+13 added/-0 removed

--local is a destination selector, not a scripted-config trigger. Document that reviewConfigureOptions.scripted intentionally ignores Local so still runs the guided picker and preselects the local settings scope. Add a regression test for Local-only configure options.

Sessions

3cf0afed4178View transcript

[?
Checkout the hand off doc that I just added.Pi·Opus 4.8·2 steps](/content/gh/entireio/cli/session/019eca64-8c2c-7b00-90c6-3aa49738c497#timeline-3cf0afed4178/index.html)

Changes

2

• cmd/entire/cli/review

• Mcmd.go+3

• Mconfigure_test.go+10

256 unmodified lines

257
258
259
260
261
262
263
264
265

256 unmodified lines

}

func (o reviewConfigureOptions) scripted() bool {
    // Local selects the destination only; by itself it must not force the
    // non-interactive/scripted path. `entire inspect --configure --local` should
    // still run the guided picker and preselect the local settings file.
    return len(o.Agents) > 0 || o.Judge != "" || o.Output != "" || o.Task != "" || len(o.Models) > 0 || len(o.Slots) > 0
}

Mcmd/entire/cli/review/cmd.go+3

409 unmodified lines

410
411
412
413
414
415
416
417
418
419
420
421
422

409 unmodified lines

})
    }
}

func TestReviewConfigureOptionsScripted_LocalOnlyDoesNotSkipInteractive(t *testing.T) {
    t.Parallel()
    if (reviewConfigureOptions{Local: true}).scripted() {
             t.Fatal("--local alone must not force scripted configure; it preselects local in the interactive scope picker")
    }
    if !(reviewConfigureOptions{Local: true, Agents: []string{tAgentClaude}}).scripted() {
         t.Fatal("--local with --set-* flags should still use scripted configure")
    }
}

Mcmd/entire/cli/review/configure_test.go+10