test(procutil): satisfy errcheck on intentional ignores · Entire

test(procutil): satisfy errcheck on intentional ignores

11cc541→main·

dipree·2w ago·1 file·+4 added/-2

Sessions

c801e3dee115View transcript

[?
Fix Multi-Agent Run Hanging and Finalization IssuesPi·Opus 4.8·1 step](/content/gh/entireio/cli/session/019f13ee-df40-718d-b2b1-aac05df371ca#timeline-c801e3dee115/index.html)

Changes

1

41 unmodified lines

42
43
44
45
45
46
47
48
49
50
5 unmodified lines

56
57
58
57
59
60

41 unmodified lines

// Drain to EOF in the background, mirroring how the reviewer reads Events.

drained := make(chan struct{})

go func() {
        _, _ = r.ReadString('\n') // blocks on the open pipe until cancel closes it
        // Blocks on the open pipe until cancel closes it; the error on close is
        // expected and the unblock itself is the assertion.
        _, _ = r.ReadString('\n') //nolint:errcheck // unblock is the assertion
        close(drained)
    }()

5 unmodified lines

t.Fatal("stdout drain did not unblock after cancel — Ctrl+C would hang")
    }

_ = cmd.Wait()
    _ = cmd.Wait() //nolint:errcheck // process was killed; exit error expected
}

Mcmd/entire/cli/procutil/procutil_unix_test.go+4/-2