strategy, trailers, clusterdiscovery: delete dead code and its tests · Entire
Strategy, Trailers, Cluster Discovery: Delete Dead Code and Its Tests
10892ce→main· Soph·2w ago·13 files·+9 added/-1,133 removed
Everything here is unreachable from the CLI entry points (verified with x/tools deadcode + reference grep) and exercised only by tests dedicated to it:
- strategy/common.go: the checkpoint-lite decode cluster (ReadCheckpointMetadata, ReadCheckpointMetadataFromSubtree, decodeCheckpointInfo, decodeSessionMetadataLite, decodeSummaryLiteFromTree, plus the private lite types) along with the bench file that was its only consumer; IsInsideWorktree and GetMainRepoRoot.
- strategy: extractUserPrompts/extractUserPromptsFromLines (prod uses splitPromptContent/readPromptsFromFilesystem), subtractFiles.
- trailers: ParseBaseCommit, ParseAllSessions, FormatTaskMetadata (prod uses FormatShadowTaskCommit) and the now-orphaned baseCommitTrailerRegex. FormatMetadata/FormatCheckpoint stay — live test infrastructure.
- clusterdiscovery: exported RenderLoginHint wrapper (the private renderLoginHint stays, used by resolve.go); reword the auth/refresh.go comment that pointed at it.
Test helpers still exercising live code (hasCheckpointURL, IsAncestorOf, ManagedGitHookNames, sessionStateFile, tokenstore fault seams, OPF config seams, contexts.Save) are kept.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Sessions
e64c28c66fb4View transcript
Changes
13
- cmd/entire/cli
- auth
- Mrefresh.go+5/-4
- strategy
- Mcommon.go-234
- Mcommon_test.go-97
- Mmanual_commit_condensation.go-131
- Mmanual_commit_condensation_test.go-34
- Mmanual_commit_hooks.go-11
- Mmanual_commit_test.go-158
- Mphase_postcommit_test.go-52
- Dreadcheckpoint_bench_test.go-233
- trailers
- Mtrailers.go-41
- Mtrailers_test.go-113
- auth
- internal/entireclient/clusterdiscovery
- Mdiscovery.go+4/-12
- Mdiscovery_test.go-13
// contextReauthError maps the two re-auth sentinels a per-context manager can
// return into a friendly message that names the context and its core (so a
// multi-core user logs back into the right one — matching
// clusterdiscovery.RenderLoginHint's idiom), preserving the sentinel for
// errors.Is. Returns nil when err is neither sentinel, leaving the caller to
// wrap the residual error in its own terms (refresh vs exchange).
// multi-core user logs back into the right one — matching the
// "no auth context, run `entire login`" hint style used by clusterdiscovery),
// preserving the sentinel for errors.Is. Returns nil when err is neither
// sentinel, leaving the caller to wrap the residual error in its own terms
// (refresh vs exchange).
func contextReauthError(c *contexts.Context, err error) error {
coreURL := strings.TrimRight(c.CoreURL, "/")
switch {
}
}
- sessionMetadataLite contains only the fields needed from session-level metadata.json.
- Using a minimal struct avoids allocating large nested objects (Summary, Attribution, TokenUsage, etc.) that Metadata carries but callers never need here.
checkpointSummaryLite
- contains only the fields needed from the root metadata.json.
- Avoids allocating TokenUsage and other heavy fields from CheckpointSummary.
func ReadCheckpointMetadata(tree checkpoint.FileReader, checkpointPath string) (*CheckpointInfo, error) {
metadataPath := checkpointPath + "/metadata.json"
file, err := tree.File(metadataPath)
if err != nil {
return nil, fmt.Errorf("failed to find metadata at %s: %w", metadataPath, err)
}
// Session metadata paths in the summary are absolute (e.g., "/ca/b75de47439/0/metadata.json").
// For a full tree, strip the leading "/" to get tree-relative paths.
normalizePath := func(raw string) string {
return strings.TrimPrefix(raw, "/")
}
return decodeCheckpointInfo(file, tree, checkpointPath, normalizePath)
}
- GetGitCommonDir returns the path to the shared git directory.
- In a regular checkout, this is .git/
- In a worktree, this is the main repo's .git/ (not .git/worktrees/
/)