test(integration): name profile for bare review invocations · Entire
test(integration): name profile for bare review invocations
0e7fb44→main· dipree·1mo ago·1 file·+6 added/-2 removed
Bare entire review now requires an explicit profile in non-interactive mode, so the two integration tests that invoked it with no args were failing with 'Specify a profile to inspect'. Pass the configured 'general' profile so they exercise the intended paths again. These are integration-tagged tests, so they were not covered by the branch's earlier go test ./... verification.
Sessions
54846e7ed8afView transcript
?\ Checkout the hand off doc that I just added.Pi·Opus 4.8·2 steps
Changes
1
cmd/entire/cli/integration_test
Mreview_test.go+6/-2
138 unmodified lines
139
140
141
142
142
143
144
145
146
147
104 unmodified lines
252
253
254
253
255
256
257
258
259
260
138 unmodified lines
t.Fatalf("write fake claude: %v", err)
}
cmd := execx.NonInteractive(context.Background(), getTestBinary(), "review")
// Bare `entire review` requires an explicit profile in non-interactive mode,
// so name the configured profile.
cmd := execx.NonInteractive(context.Background(), getTestBinary(), "review", "general")
cmd.Dir = env.RepoDir
cmd.Env = envWithOverrides(env.cliEnv(),
"PATH="+fakeBinDir+string(os.PathListSeparator)+os.Getenv("PATH"),
104 unmodified lines
},
})
output, exitErr := env.RunCLIWithError("review")
// Bare `entire review` requires an explicit profile in non-interactive mode,
// so name the configured profile to reach the skill-verification guard.
output, exitErr := env.RunCLIWithError("review", "general")
if exitErr == nil {
t.Fatalf("expected non-zero exit; output:\n%s", output)
}
Mcmd/entire/cli/integration_test/review_test.go+6/-2