Inspect cleanup: drop dead --fix manifest lookup, fix IsZero for judges

007228b→main·

dipree·1mo ago·10 files·+80 added/-252 removed

• Remove the unused resolveLocalReviewManifestBySessionID lookup (and its tests) left over from the removed entire review --fix; the manifest now only groups sibling inspector outputs for --findings.
• Update agentlaunch package doc: it's used by entire investigate fix only now.
• Fix ReviewProfileConfig.IsZero to account for judges/chair and master_agent so judge-only profiles aren't treated as empty.
• Tidy picker/cmd wording ("review profiles", not "crew profiles") and trim now-dead picker/configure test helpers.
• Mark panel synthesis tests t.Parallel().

Sessions

80aa7e660e0dView transcript

Changes

10

• cmd/entire/cli

• agentlaunch

• Mlaunch.go+5/-7

• review

• Mcmd.go+19/-14

• Mconfigure_test.go+10/-11

• Mmanifest.go+3/-32

• Mpicker.go+36/-65

• Mprofile.go+1/-1

• Msynthesis_panel_test.go+4

• settings

• Msettings.go+2/-1

// Package agentlaunch is the shared "launch a normal coding agent session
// with a composed prompt" helper, used by `entire review --fix` and
// `entire investigate fix`. Both commands feed accepted findings back into
// a follow-up coding agent without spawning a review/investigate session
// themselves.

package agentlaunch

import (

func runReviewListProfiles(ctx context.Context, cmd *cobra.Command, deps Deps) error {
    out := cmd.OutOrStdout()
    s, err := settings.Load(ctx)
    // 4. Re-run guard: check if HEAD's checkpoint already has a review.
    if proceed, guardErr := confirmReReviewOrProceed(ctx, out, deps); guardErr != nil {
        fmt.Fprintln(out, "prompt cancelled")
        return guardErr
    }
    return silentErr(guardErr)
}

// LocalReviewManifest records one local `entire review` invocation. It lets
// `entire review --fix <session-id>` use a single session id as the lookup
// handle while still loading sibling agent outputs from the same review run.
type LocalReviewManifest struct {
    Version         int              `json:"version"`
    WorktreePath    string           `json:"worktree_path"`
}

func TestBuildConfiguredProfile_FromFlags(t *testing.T) {
    t.Parallel()
    deps := configureTestDeps("claude-code", "codex")
    profile, err := buildConfiguredProfile(
        context.Background(),
    ...) // Additional test logic
}

func TestSelectReviewAgent_OverrideResolvesSpecificAgent(t *testing.T) {
    t.Parallel()
    reviewMap := map[string]settings.ReviewConfig{
        testAgentName:  {Skills: []string{"/a"}},
        testCodexAgent: {Skills: []string{"/b"}},
    }
    // Prioritizing agent selection
}

func (c ReviewProfileConfig) IsZero() bool {
    return c.Task == "" && len(c.Agents) == 0 && len(c.Judges) == 0 &&
    c.Chair == "" && c.Master == "" && c.MasterAgent == "" && c.MasterModel == ""
}